Release: Angular 19 Upgrade & Test Suite Stabilization by lordoliver · Pull Request #171 · pazznetwork/ngx-chat

lordoliver · 2026-01-14T20:27:35Z

Release: Angular 19 Upgrade & Test Suite Stabilization

Summary

This PR represents a major milestone for the project, delivering the Angular 19 / Nx 20 upgrade alongside a comprehensive stabilization of the E2E and Unit test suites.

It resolves long-standing flakiness in MUC (Multi-User Chat) tests, eliminates "zombie" processes and rooms, and introduces automated E2E testing into the CI pipeline.

All test suites (ngx-xmpp, ngx-chat-shared, xmpp-adapter, demo-e2e, ngx-chat-e2e-new) are now Passing Green ✅.

🚀 Upgrade Details

Angular 19 & Nx 20

Angular: 18.x -> 19.2.9.
Nx: 19.x -> 22.3.3.
TypeScript: ~5.6.2 (Strict compilation enabled).
Node.js: CI now runs on Node 22 (LTS).
Strictness: Fixed TS7053 (no implicit any) errors across strophe-ts, xmpp-adapter, and the demo app.

📦 Versioning

Unified Version: Root and all libraries are now synchronized to v1.19.0.
Dependencies: All libraries now explicitly require @angular/core@^19.0.0.

🤖 CI & Infrastructure Improvements

✅ Automated Testing in CI

We have enabled and integrated the following test suites into the GitHub Actions CI pipeline, ensuring they run automatically on every Pull Request:

demo-e2e: The legacy Playwright E2E suite is now fully active in CI (previously disabled/broken).
ngx-chat-e2e-new: The modern E2E suite is stabilized and enforcing regressions checks.
Unit Tests: All library unit tests are now running and passing in CI.

🛠 Pipeline Robustness

Cleanup: Added robust process termination to kill "zombie" Chrome/Node processes that previously hung the runner.
Logs: Removed excessive debug logging to prevent buffer overflows.
Budgets: Increased bundle size budgets for demo-new to match Angular 19 production builds.

🧪 Test Stabilization & Fixes

Multi-User Chat (MUC)

Zombie Room Fixes: Implemented robust cleanup using the Ejabberd Admin API to destroy rooms after tests, preventing state leakage between runs.
Race Conditions: Resolved timing issues in room joining (409 Conflict), leaving, and message history loading (MAM).
Optimization: Improved polling mechanisms and room discovery logic to prevent timeouts in CI.

E2E Fixes

demo-e2e: Verified 25/25 tests passing. Fixed selectors, timeouts, and server connectivity.
ngx-chat-e2e-new: Fixed flaky tests:
- blocking.spec.ts: Fixed race conditions when asserting blocked messages.
- message-status.spec.ts: Improved wait assertions for message receipts.
- chatbox.spec.ts: Fixed rendering race conditions.

Unit Test Fixes

Node 20+ Compatibility: Fixed unread-message-count.service.spec.ts crash by migrating from setTimeout to Angular's fakeAsync/tick.
WebSocket: Configured insecure ws:// protocol correctly for test environments.

✅ Verification

Build: nx build ngx-chat / demo-new -> Success.
Unit Tests: nx test (All Libs) -> Success.
E2E Tests: nx e2e (All Apps) -> Success.

⚠️ Breaking Changes

Angular 19 IVY: Libraries are now built with Ivy for Angular 19. They are not backward compatible with Angular 18 or older.
Peer Dependencies: strictly require ^19.0.0.

…nment

… failure

…te e2e to use wss://localhost

…ection

- Optimize ci.yml: remove duplicate lines, ensure correct caching - Fix ejabberd.yml: disable TLS on 5280 to match test env proxy - Fix proxy.conf.json: use http/127.0.0.1 for websocket proxy - Fix E2E tests: update assertions (connected->online), use EjabberdAdminPage for user management, ensure proper test setup after reloads

- libs: Force message loading in ChatHistoryComponent on init to fix reload/state issues - e2e: Update ChatWindowPage selectors to match auto-scroll DOM structure - e2e: Improve infinite-scroll test robustness with ChatWindowPage and polling assertions

… scroll tests

… reliable test

…er intersection observer

…tive/max)

…ver triggers

…nt to 50

…trigger

…croll test

…ages, no roster add)

…searching

…sponses

oschiessl added 30 commits December 21, 2025 20:43

feat: add offline messaging support, persistence fixes, and CI enviro…

32be472

…nment

ci: add github actions workflow for e2e tests

ebcb334

fix(ci): use public ejabberd image for github actions

0e2e8aa

fix(ci): add /etc/hosts entry for local-jabber domain

74e4881

fix(ci): install playwright browsers with deps

e698fd0

fix(ci): disable custom pazz_offline_push module in test env

4f06353

fix(ci): use ubuntu-22.04 runner for playwright compatibility

ef3c274

ci: enable caching for playwright browsers

03bb48e

ci: cache node_modules for faster builds

5b7505f

fix(ci): inject ejabberd admin credentials

772779b

fix(ci): wait for ejabberd health instead of sleep

7b37f5b

ci: dump docker logs on failure

0abd73d

ci: use verbose bash loop for health check wait

5ff5230

ci: use docker inspect for robust health check

bda0de7

ci: fix health check loop syntax to handle missing container

e753188

ci: fix bash exit code on arithmetic increment

a786e3a

ci: fix permission denied on ejabberd data volumes

fb8b8f6

ci: explicit admin registration to fix 401 Unauthorized

4dc4f32

ci: specify node name for ejabberdctl register

a4da63c

ci: debug connectivity with curl and dump logs on failure

fe74e26

ci: fix permission for ssl certs

f6adbf3

ci: generate self-signed ssl certs for ejabberd

3c42e11

ci: reduce test timeout to force log dump

fe75e6e

ci: enforce 5m timeout on E2E step to ensure log dump

a3e8545

fix(ci): disable TLS on websocket port 5280 to resolve E2E connection…

5f46019

… failure

fix(ci): enable TLS on ws port, increase shaper limits to 5MB/s, upda…

21c0f54

…te e2e to use wss://localhost

fix(e2e): prevent implicit form submissions and harden websocket conn…

ce2816e

…ection

fix(ci): remove and ignore local docker volume data directories

0c9f1d1

oschiessl added 30 commits January 14, 2026 22:23

fix(demo): decouple big chat from widget, fix registration flake, add…

760c731

… scroll tests

fix(e2e): robust scroll tests and roster load test fix

abd34f3

fix(core): restore stanza-id logic for infinite scroll pagination

4597f0b

fix(xmpp): resolve unread count race condition with safety buffer and…

07b076a

… reliable test

test(e2e): fix and verify scroll scenarios for big and small chat boxes

5d5745b

test(e2e): harden scroll tests with retry logic for CI reliability

cdb0fe8

test(e2e): explicitly focus widget before scrolling in CI retry loop

3c3cbdf

test(e2e): add detailed scroll debug logging and property inspector

878aa03

test(e2e): increase scroll wiggle distance to 100px to reliably trigg…

4142db3

…er intersection observer

test(e2e): add computed style debug logging for scroll container

e307326

test(e2e): fix lint error in scroll debug probe

d57f70c

test(e2e): fix widget scroll by using universal wiggle (negative/posi…

43d1447

…tive/max)

test(e2e): add async delay to universal scroll wiggle to ensure obser…

c83bb00

…ver triggers

test(e2e): enhance universal scroll wiggle with negative max target

1311a71

test(e2e): replace flaky scroll with direct Angular component trigger

f570c55

test(e2e): add debug logging for component state and increase msg cou…

7c072ed

…nt to 50

test(e2e): bump msgs to 100 and force-unlock loading state in direct …

901cb4f

…trigger

test(e2e): align widget scroll wait time (3s) with passing infinite-s…

2da8d98

…croll test

test(e2e): align widget test strictly with infinite-scroll (long mess…

cbed70e

…ages, no roster add)

chore: add MAM debug logs to investigate CI scroll failure

34ab0f4

test(e2e): capture and display debug logs on failure to avoid manual …

204f9d1

…searching

chore: add ingress logs to debug hanging MAM requests

10c51ff

chore: add version stamp and V2 logs to force cache break

8668bc7

fix(xmpp): use bare JID for MAM 'with' filter to avoid zero-result re…

94d7946

…sponses

fix: remove misplaced import statement causing syntax error

f8c3936

chore: log oldest message body and re-enable addContact in test

e63807f

chore: cleanup debugging code and restore production page size (250)

4fcdeea

chore: remove final remaining debug logs

6457d76

fix(test): revert history page size to 20 to allow pagination testing

3865093

test(e2e): finalize manual scroll test with forensic logging

92d9009

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Release: Angular 19 Upgrade & Test Suite Stabilization#171

Release: Angular 19 Upgrade & Test Suite Stabilization#171
lordoliver wants to merge 206 commits intopazznetwork:masterfrom
lordoliver:fix/green-baseline-restore

lordoliver commented Jan 14, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

lordoliver commented Jan 14, 2026

Release: Angular 19 Upgrade & Test Suite Stabilization

Summary

🚀 Upgrade Details

Angular 19 & Nx 20

📦 Versioning

🤖 CI & Infrastructure Improvements

✅ Automated Testing in CI

🛠 Pipeline Robustness

🧪 Test Stabilization & Fixes

Multi-User Chat (MUC)

E2E Fixes

Unit Test Fixes

✅ Verification

⚠️ Breaking Changes

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant