Conversation
…x_support into implement_cloud_driver
…x_support into implement_cloud_driver
…x_support into implement_cloud_driver
…x_support into implement_cloud_driver
…x_support into implement_cloud_driver
…se parsing for status extraction
| this._deviceConfig = deviceConfig; | ||
| this._sessionConfig = sessionConfig; | ||
| // @ts-ignore | ||
| this._sessionConfig.sessionId = sessionConfig.sessionId || uuid.UUID(); |
There was a problem hiding this comment.
When multiple test suites are present in a session, web socket connection is closed after the execution of each test suite, and a new web socket connection is created, thus web socket id changes, but session id remains constant for each test suite. Therefore, to ensure that the same device is used for all the test suites in a test, we want this unique identifier(session_id). Thus, we cannot let users define this.
|
|
||
| get timeout() { | ||
| return 1000; | ||
| return 240000; |
There was a problem hiding this comment.
This timeout is increased because in cloud sessions, we do device allocation/app installation, etc after receiving this message and then return the reponse to it.
| if (isCloudSession) { | ||
| cliConfig.reuse = false; | ||
| cliConfig.cleanup = false; | ||
| cliConfig.reuse = true; |
There was a problem hiding this comment.
Changed default value for reuse to true and shutdownDevice to false for cloud sessions
| if (session.build != null) { | ||
| const value = session.build; | ||
| if (typeof value !== 'string' || value.length === 0) { | ||
| if (typeof value !== 'string') { |
There was a problem hiding this comment.
We can allow empty string for build/project/name options.
| @@ -0,0 +1,76 @@ | |||
| class CloudArtifactsManager { | |||
There was a problem hiding this comment.
We have created this ArtifactsManager class because artifacts are being managed by us and we don't want any logs related to artifacts management in our tester logs.
All the methods here are the callbacks for the events happening throughout the test cycle
| await this.uiDevice.pressHome(); | ||
| } | ||
|
|
||
| // Deep to come back |
There was a problem hiding this comment.
we should remove this comment
| } | ||
| } | ||
|
|
||
| // Do we want to throw error if terminate app fails |
There was a problem hiding this comment.
what's the resolution of this?
There was a problem hiding this comment.
If terminate app fails, hub sends serverError type in response because of which script exits.
2 participants
Description
In this pull request, I have …