Open
Conversation
cmsegal
force-pushed
the
use-protobuf-for-sync
branch
2 times, most recently
from
d2719b1 to
8f92163
Compare
pcsegal
force-pushed
the
use-protobuf-for-sync
branch
from
8f92163 to
818d7e0
Compare
pcsegal
force-pushed
the
use-protobuf-for-sync
branch
from
818d7e0 to
cd9d316
Compare
mgazza
approved these changes
Nov 18, 2025
Collaborator
mgazza
left a comment
mgazza
left a comment
There was a problem hiding this comment.
Excellent improvement to use Protocol Buffers for sync messages. This provides better performance, type safety, and forward/backward compatibility compared to JSON.
Key improvements:
- Binary serialization is more efficient than JSON
- Type-safe enums for message types (SYNC_REQUEST/SYNC_RESPONSE)
- Uses msgio for proper length-delimited framing
- Separate read/write deadlines for better stream control
- Clean conversion functions between internal and protobuf types
The reduction of sync batch size from 100k to 10k is also sensible for better memory management.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.