Open
Conversation
Owner
|
If you vendor the dependencies using glide, it should build - I should probably update the docs and/or migrate to dep/vgo. Will need to update the glide deps at a minimum to merge this, otherwise the build will be broken for users building with vendoring. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempting to build is currently throwing the following message.
The interface of the
satori/go.uuidpackage changed such that there is the potential to return an error. I've made the code simply panic in this case as this is something that should basically never happen unless the random number generator fails - in which case you likely have bigger problems.