130 each game of rankify instance shall be a separate contract#178
Draft
130 each game of rankify instance shall be a separate contract#178
Conversation
…te Solidity contracts, libraries, and scripts related to the Rankify instance and diamond architecture.
…t and DiamondDistribution, streamlining the project structure.
- Added `viaIR` and `evmVersion` settings in the Hardhat configuration. - Adjusted optimizer runs from 2000 to 200 for better performance. - Introduced contract sizer settings for improved contract management. - Updated package dependencies: - Changed `@peeramid-labs/eds` to a local file reference. - Upgraded `hardhat` to version 2.22.19. - Updated `@openzeppelin/contracts` and `@openzeppelin/contracts-upgradeable` to version 5.3.0.
…liminate obsolete code.
- Changed function visibility from private to internal for several functions to allow access from derived contracts. - Updated the transferFromAny, fulfillERC72Balance, and _release functions accordingly.
🦋 Changeset detectedLatest commit: 5b56259 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
* Remove unused files and clean up project structure by deleting obsolete Solidity contracts, libraries, and scripts related to the Rankify instance and diamond architecture. * Remove obsolete Solidity contracts related to ArguableVotingTournament and DiamondDistribution, streamlining the project structure. * Remove LibEIP712Storage library to streamline project structure and eliminate obsolete code. * Remove DAODistributor contract and deprecated code to streamline project structure.
…ify-instance-shall-be-a-separate-contract
…ture and eliminate deprecated code.
…de to prepare for future refactoring and updates.
…structure and eliminate deprecated code.
…te deprecated code.
* feat: add Fellowship contract and related interfaces - Introduced the Fellowship contract to manage game mechanics and user ranks. - Added IFellowship interface for contract interactions. - Implemented LibACID library for handling tournament logic and state management. - Created FellowshipAgent script for game setup and management. - Established mock voting and environment setup for testing purposes. * Refactor Fellowship contract to integrate RankToken functionality and streamline initialization. Removed deprecated code and adjusted state variables for improved clarity and efficiency. Updated interfaces and library dependencies to reflect new structure. * Refactor setupMockEnvironment to export setupAddresses function for improved accessibility. Update RankToken tests to utilize the new setup function, enhancing clarity and organization of test cases. * Integrate LibMiddleware and AuthorizationMiddleware into Fellowship contract. Update FELLOWSHIP_STORAGE_POSITION calculation for improved storage management. Enhance code clarity with additional comments. * Implement BaseEnvironmentSimulator class for enhanced testing capabilities. Refactor FellowshipAgent to extend BaseEnvironmentSimulator, improving code organization. Update hardhat.config.ts for conditional contract sizing. Add Fellowship contract tests for installation, uninstallation, and upgrades, while removing obsolete test files. * changeset * changeset
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.