Improve logging on backend #1015
Open
+159
−55
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vortexfi ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for vortex-sandbox ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request introduces an AsyncLocalStorage-based ramp processing context system to automatically propagate rampId throughout asynchronous operations, improving logging and error tracking capabilities. The system eliminates the need to explicitly pass rampId through function parameters by making it available via context in all nested async operations.
Changes:
- Added a new
ramp-context.tsmodule implementing AsyncLocalStorage for ramp context management - Modified logger format to automatically include
rampIdfrom context when available - Wrapped ramp processing entry points with
runWithRampContextin phase processor, recovery worker, and cleanup worker
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| apps/api/src/config/ramp-context.ts | New module implementing AsyncLocalStorage for automatic rampId propagation through async call chains |
| apps/api/src/config/logger.ts | Updated logger format to retrieve and display rampId from context, and applied custom format to console transport |
| apps/api/src/api/workers/ramp-recovery.worker.ts | Wrapped recovery operations with runWithRampContext and removed explicit rampId from log messages |
| apps/api/src/api/workers/cleanup.worker.ts | Wrapped cleanup operations with runWithRampContext to provide context for post-processing handlers |
| apps/api/src/api/services/phases/phase-processor.ts | Wrapped main processRamp method with runWithRampContext to establish context for entire phase processing flow |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Member
Author
Contributor
Co-authored-by: ebma <6690623+ebma@users.noreply.github.com>
Remove nested context wrapper and fix logger spacing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a new ramp processing context system using
AsyncLocalStorageto automatically propagaterampIdthroughout asynchronous call chains. The main goal is to improve logging and error tracking by ensuring every log message and error handler can access the relevantrampIdwithout explicitly passing it around. This change affects ramp processing, cleanup, and recovery workflows, as well as the logger output format.The logs now include the rampId when available/applicable, see for example: