-
Notifications
You must be signed in to change notification settings - Fork 3
ready: chore/implement smartFallbackTransport #991
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: staging
Are you sure you want to change the base?
Conversation
✅ Deploy Preview for vortexfi ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
✅ Deploy Preview for vortex-sandbox ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
ebma
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Sharqiewicz did you test the things listed in the 'Test plan'? We need to make sure that this is not a downgrade, especially considering that previously we were shuffling the connections with a bit of randomness and now we are not anymore.
| } | ||
|
|
||
| /** | ||
| * @deprecated Use readContract instead. Retry logic is now handled at transport level. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If this is now deprecated, let's rather remove the whole function and adjust the existing calls to it to use the other function.
| } | ||
|
|
||
| /** | ||
| * @deprecated Use sendTransaction instead. Retry logic is now handled at transport level. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here
| } | ||
|
|
||
| /** | ||
| * @deprecated Use sendRawTransaction instead. Retry logic is now handled at transport level. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same here
Summary
Test plan