Conversation
Codecov Report
@@ Coverage Diff @@
## master #179 +/- ##
==========================================
- Coverage 75.46% 70.21% -5.26%
==========================================
Files 23 24 +1
Lines 1011 1155 +144
==========================================
+ Hits 763 811 +48
- Misses 248 344 +96
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Can you open a single PR blacking the whole project before proceeding? That would make reviewing the rest much easier |
|
I'd also vote for making black the official Code-Style and adding pre-commit hooks for that :-) |
|
member_database/models/sepa.py
Outdated
| creation_date = db.Column(db.DateTime(timezone=True), nullable=False) | ||
|
|
||
| @validates("iban") | ||
| def validate_iban(self, key, iban): |
There was a problem hiding this comment.
mmh, don't roll your own? Sure we need to implement this ourselves...? This should definitely be tested
There was a problem hiding this comment.
Yes we need to test this, generally this PR needs tests.
(I did not fully write this myself, though, I tuned an implementation I found on GitHub)
| # ### end Alembic commands ### | ||
|
|
||
|
|
||
| def downgrade(): |
There was a problem hiding this comment.
It is possible in alembic to not implement the downgrade. Since this might remove data we need to keep, maybe this would be a point where we don't allow the downgrade.
3 participants
Added basic mechanism to add a sepa lastschriftmandat to the db.
Still a little rough around the edges, so I need more help on this. Tests are still completely misssing...
Fixes #114