Add --base-path support for reverse proxy subpath deployment#713
Open
d0nperinion wants to merge 2 commits intoperber:mainfrom
Open
Add --base-path support for reverse proxy subpath deployment#713d0nperinion wants to merge 2 commits intoperber:mainfrom
d0nperinion wants to merge 2 commits intoperber:mainfrom
Conversation
Allow serving LeafWiki from an arbitrary URL prefix (e.g. /wiki) when behind a reverse proxy. Routes, API calls, static assets, and cookies are all scoped to the configured base path.
Owner
|
Hi @d0nperinion, Thanks for your PR. Could you run |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
/wiki
Backend changes
format (or "" for root), passed to RouterOptions.BasePath
/branding, /static, /favicon.svg) under it. NoRoute stays on router but strips basePath before checking prefixes. Replaces {{BASE_PATH}} in
index.html. Added basePath to /api/config response. Passes cookiePath to cookie constructors.
hardcoded Path: "/" with Path: a.CookiePath
Frontend changes
relative links
Test fixes
Updated all NewAuthCookies() and NewCSRFCookie() calls in test files to include the new cookiePath parameter ("/").
vibecoded this in a hour, looks like it works.