Allow Manual QA GitHub action run with single OS trigger option instead of ALL of them #2446
+68
−21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ly one OS for quick testing. Maintains backwards compatibility to always run all by default and when not being run manually.
…ly one OS for quick testing. Maintains backwards compatibility to always run all by default and when not being run manually.
Contributor
Author
|
I'm not quite sure why the QA run failed, I've successfully used this exact workflow in my branch. It definitely works in my fork, and I wonder if something to do with the existing QA workflow (in the current Anyway, if you're not convinced of it's use, we can drop it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change allows the Manual QA invocation from the Github actions to now take a selected OS/platform option so that you can just run a single operating system QA cycle.
I found this useful to devote some problems without launching the tire set of operating systems, which is fairly heavyweight.
Defaults to
allmaintaining backwards compatibility, but provides a selector of the platforms to run if you just want to select one.