Release/1.5.0 by mehul0810 · Pull Request #64 · performwp/perform

mehul0810 · 2025-11-03T05:03:13Z

Changes

Migrated the settings to WP Design System and React based UI
Restructured the organization of the settings for better context

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Added blueprint.json for live preview

Updated gpl license from gpl-2 to gpl-3 #39

github-actions · 2025-11-03T05:03:25Z

Test on Playground
Test this pull request on the Playground

Copilot

Pull Request Overview

This PR introduces a major refactoring of the Perform plugin's settings interface, migrating from a traditional PHP-rendered settings page to a React-based single-page application. The changes update the plugin to version 1.5.0 and change the license from GPLv2 to GPLv3.

Key changes:

React-based settings UI using WordPress components
Centralized settings field definitions in Helpers class
Enhanced security with nonce verification and capability checks
Improved field sanitization logic based on field types
Updated GitHub repository references and bug report URLs

Reviewed Changes

Copilot reviewed 17 out of 18 changed files in this pull request and generated 10 comments.

Show a summary per file

File	Description
perform.php	Updates version to 1.5.0 and changes license to GPLv3
package.json	Adds WordPress React dependencies and updates version/license
webpack.config.js	Updates GitHub repository URL and removes trailing space
src/Includes/Helpers.php	Adds extensive settings field definitions and helper methods
src/Admin/Settings/Menu.php	Refactors to use React app with localized data
src/Admin/Actions.php	Adds WordPress components and localizes settings data
assets/src/js/admin/*.jsx	New React components for settings interface
assets/src/css/admin/settings.css	New styles for React-based settings page

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-11-03T05:05:35Z

src/Includes/Helpers.php

-			return array_map( [ __CLASS__, __METHOD__ ], $var );
-		} else {
-			return is_scalar( $var ) ? sanitize_text_field( wp_unslash( $var ) ) : $var;
+			// Recursively clean array values by calling this same method.


[nitpick] The refactored code now uses an explicit method name 'clean' instead of METHOD. While this works correctly, the original METHOD approach was more maintainable as it would automatically update if the method is renamed. Consider adding a comment explaining why the explicit method name is preferred here, or document that method renaming should update this reference.

Suggested change

// Recursively clean array values by calling this same method.

// Recursively clean array values by calling this same method.

// Note: The method name 'clean' is used explicitly here for recursion.

// If this method is renamed, update the string 'clean' accordingly.

src/Admin/Settings/Menu.php

Copilot · 2025-11-03T05:05:36Z

src/Admin/Settings/Menu.php

+							// If associative array (value=>label) check keys, otherwise check values
+							$keys = array_keys( $opts );
+							$vals = array_values( $opts );
+							if ( array_diff_key( $opts, array_values( $opts ) ) ) {


This logic to detect associative arrays is unclear and potentially fragile. The condition checks if the array has different keys after array_values(), but this is an indirect way to detect associative arrays. Consider using a clearer approach like checking if array_keys($opts) !== range(0, count($opts) - 1) or adding a helper function with a descriptive name like 'is_associative_array()'.

Suggested change

if ( array_diff_key( $opts, array_values( $opts ) ) ) {

if ( array_keys( $opts ) !== range( 0, count( $opts ) - 1 ) ) {

Copilot · 2025-11-03T05:05:36Z

assets/src/js/admin/SettingsApp.jsx

+    setSaving(true);
+    setMessage(null);
+    try {
+      const res = await fetch(ajaxurl, {


The code uses the global 'ajaxurl' variable without checking if it exists. While this is typically available in WordPress admin, it's better to access it safely via window.ajaxurl or provide a fallback. Consider adding a check or using window.performwpSettings to pass the ajax URL explicitly.

Suggested change

const res = await fetch(ajaxurl, {

const ajaxUrl = window.performwpSettings?.ajaxurl || window.ajaxurl;

if (!ajaxUrl) {

throw new Error('AJAX URL not defined.');

}

const res = await fetch(ajaxUrl, {

Copilot · 2025-11-03T05:05:37Z

assets/src/js/admin/SettingsApp.jsx

+        // mutate initialValues object won't update memo, so reset by rebuild: setFieldValues equals current, but we need to reset initialValues - simplest approach: set initial snapshot to current by resetting via a state.
+        // We'll set the initialValues by replacing the state used for comparison: emulate by setting all initialValues to current values via a ref - but here we'll just clear dirty by resetting initialValues via resetting fieldValues baseline.
+        // For simplicity, update initialValues by assigning to window.performwpSettings._initial = fieldValues (not ideal), but we can update local initialValues via a small trick: setFieldValues to same and update a savedSnapshot state.
+        // Implement savedSnapshot state instead.


These commented-out thoughts/implementation notes should be removed. They describe the problem-solving process but don't add value to the final code. The implementation using savedSnapshot is clear from the code itself. Remove these comments to improve code cleanliness.

Suggested change

// mutate initialValues object won't update memo, so reset by rebuild: setFieldValues equals current, but we need to reset initialValues - simplest approach: set initial snapshot to current by resetting via a state.

// We'll set the initialValues by replacing the state used for comparison: emulate by setting all initialValues to current values via a ref - but here we'll just clear dirty by resetting initialValues via resetting fieldValues baseline.

// For simplicity, update initialValues by assigning to window.performwpSettings._initial = fieldValues (not ideal), but we can update local initialValues via a small trick: setFieldValues to same and update a savedSnapshot state.

// Implement savedSnapshot state instead.

Copilot · 2025-11-03T05:05:37Z

assets/src/js/admin/main.js

+  }
+});
+
+


The file contains both the new React app initialization (lines 4-12) and what appears to be legacy code for the old form-based settings (lines 15+). If the old PHP-rendered form is no longer used, this legacy code should be removed. If both approaches coexist during a transition period, add comments explaining this temporary state.

Suggested change

// TEMPORARY: The following legacy form-handling code is retained during the transition to the new React-based settings page.

// Once all settings functionality has been migrated to React, this code can be safely removed.

Copilot · 2025-11-03T05:05:37Z

assets/src/js/admin/Footer.jsx

+      justifyContent: 'flex-end',
+      gap: 12,
+      alignItems: 'center',
+	  marginBottom: '-20px',


[nitpick] Using a negative margin to adjust positioning is a code smell that suggests the layout structure may need adjustment. Consider reviewing the parent container's padding/margin instead of using negative values, which can cause unexpected layout issues and make the component less reusable.

Suggested change

marginBottom: '-20px',

Copilot · 2025-11-03T05:05:37Z

src/Admin/Settings/Menu.php

+						$sanitized_post[ $key ] = sanitize_text_field( $raw_val );
+				}
+			} else {
+				// No field definition found – fall back to a safe cleaning


When no field definition is found, the code falls back to sanitize_text_field for scalar values. However, this may not be appropriate for all field types (e.g., URLs, emails, numbers). Consider logging a warning when a field definition is not found, as this could indicate a mismatch between frontend and backend field definitions, potentially allowing unsanitized data if Helpers::clean() doesn't handle the specific data type properly.

Suggested change

// No field definition found – fall back to a safe cleaning

// No field definition found – log a warning and fall back to a safe cleaning

error_log(

sprintf(

'[Perform] Warning: No field definition found for key "%s" with value "%s". Falling back to sanitize_text_field or Helpers::clean. This may indicate a mismatch between frontend and backend field definitions.',

$key,

is_scalar( $raw_val ) ? (string) $raw_val : json_encode( $raw_val )

)

);

Copilot · 2025-11-03T05:05:38Z

assets/src/js/admin/Footer.jsx

@@ -0,0 +1,35 @@
+import { Button, Spinner } from '@wordpress/components';
+import { useEffect } from '@wordpress/element';


Unused import useEffect.

Suggested change

import { useEffect } from '@wordpress/element';

assets/src/js/admin/SettingsApp.jsx

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Ankur0812 and others added 28 commits November 14, 2024 12:03

Update gpl license from gpl-2 to gpl-3 #39

ba15359

Added blueprint.json #40

ed1d72f

Update assets/blueprints/blueprint.json

eacba36

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Merge pull request #43 from performwp/add-blueprint.json-40

9fedb24

Added blueprint.json for live preview

Merge pull request #42 from performwp/fix-issue-39

1bca67c

Updated gpl license from gpl-2 to gpl-3 #39

Merge branch 'master' into develop

ec9c67a

change git repo to org repo

40dc5ad

updated package lock json

d648a67

add settings app using react

e6227d0

added settings header

1c9cb06

added settings navigation

b39cf87

loading of section and fields

188b152

show fields with relevant components

d749b53

added support for some more settings

0b2e42e

implemented new settings ui

52c6fa8

remove legacy settings section

7eb16fa

improve ui for footer section

4fb977b

updated setting fields

14ac81b

added support for textarea control

6908623

added support for help link

d2ef20b

improve the card layout ui

b4e1e20

added capability check for save settings

784c13c

improved clean helper fn

90da8dd

improved field specific sanitization

d78f942

update version to 1.5.0

9b264c6

update language pot file

c99c61a

fix menu cache migration issue

265ba6d

fix ssl migration issue

db8adad

mehul0810 requested a review from Copilot November 3, 2025 05:03

Copilot AI reviewed Nov 3, 2025

View reviewed changes

Mehul Gohil and others added 12 commits November 3, 2025 10:43

add scripts to composer

945a28f

removed unused variable

c82014d

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

remove unnecessary inline comment

5510a93

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

minor fixes for automation with gh

49d67dc

minor fix for lint automation

1afd38b

some more fixes to yml files

87ae9cd

update composer json

b145b66

minor improvements

a966760

relocate assets for wp org plugin

90c6fd6

update banner images

1332af0

update readme txt file

55daa79

added some cta

115b3ba

mehul0810 merged commit 3030abf into master Nov 3, 2025
1 of 10 checks passed

mehul0810 deleted the release/1.5.0 branch November 3, 2025 07:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Release/1.5.0#64

Release/1.5.0#64
mehul0810 merged 40 commits intomasterfrom
release/1.5.0

mehul0810 commented Nov 3, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Nov 3, 2025 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Nov 3, 2025

Uh oh!

Uh oh!

Copilot AI Nov 3, 2025

Uh oh!

Copilot AI Nov 3, 2025

Uh oh!

Copilot AI Nov 3, 2025

Uh oh!

Copilot AI Nov 3, 2025

Uh oh!

Copilot AI Nov 3, 2025

Uh oh!

Copilot AI Nov 3, 2025

Uh oh!

Copilot AI Nov 3, 2025

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

	if ( array_diff_key( $opts, array_values( $opts ) ) ) {
	if ( array_keys( $opts ) !== range( 0, count( $opts ) - 1 ) ) {

-      const res = await fetch(ajaxurl, {
+      const ajaxUrl = window.performwpSettings?.ajaxurl || window.ajaxurl;
+      if (!ajaxUrl) {
+        throw new Error('AJAX URL not defined.');
+      }
+      const res = await fetch(ajaxUrl, {



	// TEMPORARY: The following legacy form-handling code is retained during the transition to the new React-based settings page.
	// Once all settings functionality has been migrated to React, this code can be safely removed.

-				// No field definition found – fall back to a safe cleaning
+				// No field definition found – log a warning and fall back to a safe cleaning
+				error_log(
+					sprintf(
+						'[Perform] Warning: No field definition found for key "%s" with value "%s". Falling back to sanitize_text_field or Helpers::clean. This may indicate a mismatch between frontend and backend field definitions.',
+						$key,
+						is_scalar( $raw_val ) ? (string) $raw_val : json_encode( $raw_val )
+					)
+				);

		@@ -0,0 +1,35 @@
		import { Button, Spinner } from '@wordpress/components';
		import { useEffect } from '@wordpress/element';

		}
		});

Uh oh!

Conversation

mehul0810 commented Nov 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Uh oh!

github-actions bot commented Nov 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Copilot AI Nov 3, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI Nov 3, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 3, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 3, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 3, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 3, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 3, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Nov 3, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

mehul0810 commented Nov 3, 2025 •

edited

Loading

github-actions bot commented Nov 3, 2025 •

edited

Loading