Restore test suite, remove content length request#7
Open
sj26 wants to merge 2 commits intopeterhellberg:masterfrom
Open
Restore test suite, remove content length request#7sj26 wants to merge 2 commits intopeterhellberg:masterfrom
sj26 wants to merge 2 commits intopeterhellberg:masterfrom
Conversation
We can ask for the last 4096 bytes of the zip file without it.
sj26
force-pushed
the
skip-head-request
branch
from
6d16cdf to
d6db574
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey there! I always loved the idea of this gem. I love how simple it is. But I've never had reason to use it -- until recently.
I dug in a little and noticed the test suite wasn't really running, so I did a little update to get that working and add
net-httpas an explicit dependency as required by modern ruby. And, sadly, Rubinius is long gone. I also had to remove the basic auth tests because that doesn't seem to be enforced at the test endpoint any more.Then I noticed that the gem does an initial request to get the content-length - but this isn't required. You can ask for the last 4096 bytes of a remote resource by specifying
Range: bytes=-4096which Net::HTTP supports as#set_range(-4096)and which simplifies the implementation.Not sure if you're interested in contributions, but I offer it at your leisure 🙏