Open
Conversation
Owner
|
Thanks, @milesfrain. I've had it on my radar to make the necessary research and fixes to make Ojo work on Ubuntu 20.04+. Help from someone more familiar with Webkit 4.0 appreciated on this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looks like gir1.2-webkit-3.0 on bionic (18.04) was updated to gir1.2-webkit2-4.0 on focal (20.04).
This PR is an initial attempt to apply those updates; however, a more involved rewrite is required to incorporate the WebKit2 API. For example, there's no longer a
set_transparentmethod or"status-bar-text-changed"signal.I'm not going to be spending any more time on this update, but wanted to share some progress so far in case anyone else wants to continue effort.
I'm testing this by running
bin/ojoas described in the contributing instructions.