🚀 Project Improvements - Version Bump to 2.1.1#180
Open
rafaelpadilla wants to merge 20 commits intopetrobras:mainfrom
Open
🚀 Project Improvements - Version Bump to 2.1.1#180rafaelpadilla wants to merge 20 commits intopetrobras:mainfrom
rafaelpadilla wants to merge 20 commits intopetrobras:mainfrom
Conversation
Co-authored-by: Rafael Padilla <31217453+rafaelpadilla@users.noreply.github.com>
…) typings. Also made the test check if model typing class has "predict" method.
…ecorator to some functions in base_preprocessing.py.
Contributor
Author
ℹ️ InfoI targeted the |
Collaborator
|
Hi, @rafaelpadilla. I hope this PR will result in another significant contribution from the Federal University of Rio de Janeiro to the 3W Project. We will evaluate it ASAP and will let you know here if we have any questions and/or requests for adjustments. On behalf of the 3W Community, I thank you for this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This pull request delivers a set of fixes, refactors, and standardization efforts aimed at improving correctness, robustness, readability, and consistency across the codebase. The scope of this delivery is centered on quality improvements rather than new features.
Given the scope and impact of these improvements, this pull request suggests a bump to v2.1.1.
Summary of Changes
1. Dataset Example Cleanup and Label Consistency
Inconsistent results in
dataset_examples.ipynbwere investigated.2. Git Ignore and HTML Directory Handling
The
.gitignorefile was updated to correctly handle the HTML directory.3. Notebook Error Investigation and Fixes
Errors and execution issues were investigated and addressed in the following notebooks:
mlp_timeseries_example.ipynb,notebooks/feature_extraction_examples.ipynb,overview_version_2.0.0.ipynbandusing_metrics.ipynb4. Adding a new script to automate the validation of Jupyter notebooks
This delivery introduces the
bin/nb_testscript to automate the validation of Jupyter notebooks. The script executes all.ipynbfiles within a specified directory, defaulting todocs/notebooks, and fails fast if any notebook raises an error during execution. These updates ensure that the notebooks run cleanly and accurately reflect the current state of the library.5. SSL errors related to the dataset hosted in Figshare
Fixes for SSL related errors noted in FigShare during the downloading of the dataset were addressed.
6. Replacement of
AnyType AnnotationsAll remaining uses of the generic
Anytype were replaced with more specific and explicit type annotations. This improves static analysis, readability, and overall type safety across the codebase.7. Variable Renaming for Improved Readability
Non descriptive variable names such as
vand k`` were replaced with clearer, more meaningful alternatives. This improves code readability and long term maintainability.8. Addition of Missing Docstrings in Validation Functions
All
validate_ functionswere reviewed and updated to include missing docstrings. The new documentation follows the established documentation style guidelines, improving clarity for users and contributors.9.
EnumNaming and Selector StandardizationMissing
Enumsuffixes were added where applicable to ensure consistent naming.Final Notes
These changes focus on correctness, consistency, and maintainability, strengthening both the internal code quality and the reliability of user facing examples and notebooks.
Thank you for reviewing this delivery.
🎉🥳🎊🚀✨
By creating this pull request, I confirm that I have read and fully accept and agree with one of the Petrobras' Contributor License Agreements (CLAs):
Our CLAs are based on the Apache Software Foundation's CLAs: