Add is_ipv6_address validation to pfesnsible.core.pfsense_dns_resolver for hosts and domainoverrides #226
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add is_ipv6_address validation to dns_resolver hosts and domainoverrides Even though the documentation indicates that `['hosts']['ip']` `['domainoverrides']['ip']` allows for IPv6, the code validation does not. Simply permit both IPv4 and IPv6, as per the documentation: https://github.com/pfsensible/core/blob/master/plugins/modules/pfsense_dns_resolver.py#L123 https://github.com/pfsensible/core/blob/master/plugins/modules/pfsense_dns_resolver.py#L161
dmckeone
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
is_ipv6_addressvalidation topfesnsible.core.pfsense_dns_resolverforhostsanddomainoverridesEven though the documentation indicates that
['hosts']['ip']['domainoverrides']['ip']allows for IPv6, the code validation does not. Simply permit both IPv4 and IPv6, as per the documentation:Documentation (commit as of today) stating IPv6 is allowed:
core/plugins/modules/pfsense_dns_resolver.py
Line 123 in eba1c3a
core/plugins/modules/pfsense_dns_resolver.py
Line 161 in eba1c3a