Skip to content

Conversation

@josie-atkins
Copy link
Contributor

@josie-atkins josie-atkins commented Oct 13, 2025

Rebates uses input parameters of type Class, with jakarta annotations set on the fields of that class. This PR will:

  • Extend the existing work to pass through jakarta annotions as directives on input object fields.
  • Only process directives at valid locations.

Review tips:

@josie-atkins josie-atkins marked this pull request as draft October 13, 2025 04:24
@josie-atkins josie-atkins marked this pull request as ready for review October 19, 2025 22:04
@josie-atkins josie-atkins marked this pull request as draft October 19, 2025 22:16
@josie-atkins josie-atkins marked this pull request as ready for review October 20, 2025 02:11
@josie-atkins josie-atkins marked this pull request as draft October 20, 2025 03:25
@josie-atkins josie-atkins marked this pull request as ready for review November 3, 2025 02:58
Copy link
Contributor

@ashley-taylor ashley-taylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice. Like the tests and taking advantage of new language features to make the code more readable

@ashley-taylor ashley-taylor merged commit d0a9495 into master Nov 3, 2025
2 checks passed
@ashley-taylor ashley-taylor deleted the RBT-928-add-annotations-as-directoves-from-constructor-parameters-and-class-fields branch November 3, 2025 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants