Fix 36 high-severity log injection (cs/log-forging) vulnerabilities

[Copilot]

Summary

User-controlled values (process IDs, names, tenant IDs, etc.) were flowing unsanitized into ILogger calls across multiple layers, enabling log forging attacks (CodeQL cs/log-forging).

Changes

• New LogSanitizer utility (src/Shared/Utilities/LogSanitizer.cs) — Sanitize(string?) strips all control characters (newlines, carriage returns, etc.) with an allocation-free fast path for clean strings

// Before
_logger.LogInformation("Process {ProcessId} created", processId);

// After
using static CognitiveMesh.Shared.LogSanitizer;
_logger.LogInformation("Process {ProcessId} created", Sanitize(processId));

• Applied Sanitize() to all 8 flagged files:

  • InMemoryAuditLoggingAdapter — entry.EntryId, entry.ProcessId, processId
  • InMemoryCognitiveDebtAdapter — processId, phaseId
  • InMemoryPhaseConditionAdapter — processId, phaseId
  • CognitiveSandwichController — all processId and targetPhaseId route parameters
  • CognitiveSandwichEngine — processId, process.Name, phaseId, nextPhase.Name, reason.Reason
  • ConvenerController — ideaId, tenantId
  • DiscoverChampionsUseCase — request.TenantId, request.SkillFilter
  • CommunityPulseService — request.TenantId, request.ChannelId

• Enum values intentionally excluded — EventType (an enum) cannot contain control characters; wrapping it caused a build error that was corrected

Related Issues

Architecture Layer

• FoundationLayer
• ReasoningLayer
• MetacognitiveLayer
• AgencyLayer
• BusinessApplications
• Infrastructure / CI/CD

Checklist

• Code compiles without warnings (dotnet build passes with TreatWarningsAsErrors)
• XML documentation added for all new public types (CS1591)
• Unit tests added or updated
• All tests pass (dotnet test)
• No circular dependencies introduced between layers
• No secrets or credentials committed

Test Plan

CodeQL re-scan on the branch after applying Sanitize() — all 36 cs/log-forging alerts resolve. Enum-typed arguments (EventType) verified to compile without sanitization.

Screenshots

---

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

[greptile-apps]

No reviewable files after applying ignore patterns.