#1048: Update laravel package code to reflect namespace changes#22
Closed
debo wants to merge 1 commit intophp-telegram-bot:masterfrom
debo:feature/1048-better-namespace
Closed
#1048: Update laravel package code to reflect namespace changes#22debo wants to merge 1 commit intophp-telegram-bot:masterfrom debo:feature/1048-better-namespace
debo wants to merge 1 commit intophp-telegram-bot:masterfrom
debo:feature/1048-better-namespace
Conversation
Member
|
Closed due to new code base with v2.0 |
Author
|
You could have asked me to update the PR to be compliant rather than close it to be fair, but hey. Is it worth for me to open a new one? |
Member
|
We completely replaced the code base of the laravel integration. I didn't check exactly what it was about, since the codebase is different and it's not applicable anyway. Sorry for the inconvenience. |
Author
|
It was about unifying the namespaces and make them more meaningful and in context. You can see the details in the linked issue. Happy to open a new PR compatible with the current codebase. Just let me know also because it Hacktoberfest now ;) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR to support the suggestion made here of changing the core library namespace.