Skip to content

remove ArrayAccess::offsetExists() mocks #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xabbuh merged 1 commit into from
Jan 20, 2025
Merged

remove ArrayAccess::offsetExists() mocks #85

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 0 additions & 3 deletions spec/ActivityProfileDocumentSpec.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,11 +35,8 @@ function it_is_a_document()

function its_data_can_be_read()
{
$this->offsetExists('x')->shouldReturn(true);
$this->offsetGet('x')->shouldReturn('foo');
$this->offsetExists('y')->shouldReturn(true);
$this->offsetGet('y')->shouldReturn('bar');
$this->offsetExists('z')->shouldReturn(false);
}

function it_throws_exception_when_not_existing_data_is_being_read()
Expand Down
3 changes: 0 additions & 3 deletions spec/AgentProfileDocumentSpec.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,11 +36,8 @@ function it_is_a_document()

function its_data_can_be_read()
{
$this->offsetExists('x')->shouldReturn(true);
$this->offsetGet('x')->shouldReturn('foo');
$this->offsetExists('y')->shouldReturn(true);
$this->offsetGet('y')->shouldReturn('bar');
$this->offsetExists('z')->shouldReturn(false);
}

function it_throws_exception_when_not_existing_data_is_being_read()
Expand Down
4 changes: 0 additions & 4 deletions spec/ExtensionsSpec.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,16 +27,13 @@ function its_extensions_can_be_read()
$extensions->attach(IRI::fromString('http://id.tincanapi.com/extension/starting-position'), 1);
$this->beConstructedWith($extensions);

$this->offsetExists(IRI::fromString('http://id.tincanapi.com/extension/topic'))->shouldReturn(true);
$this->offsetGet(IRI::fromString('http://id.tincanapi.com/extension/topic'))->shouldReturn('Conformance Testing');

$this->offsetExists(IRI::fromString('http://id.tincanapi.com/extension/color'))->shouldReturn(true);
$this->offsetGet(IRI::fromString('http://id.tincanapi.com/extension/color'))->shouldReturn(array(
'model' => 'RGB',
'value' => '#FFFFFF',
));

$this->offsetExists(IRI::fromString('http://id.tincanapi.com/extension/starting-position'))->shouldReturn(true);
$this->offsetGet(IRI::fromString('http://id.tincanapi.com/extension/starting-position'))->shouldReturn(1);

$returnedExtensions = $this->getExtensions();
Expand All @@ -54,7 +51,6 @@ function it_throws_exception_when_keys_are_passed_that_are_not_iri_instances_dur

function it_throws_exception_when_keys_are_passed_that_are_not_iri_instances()
{
$this->shouldThrow('\InvalidArgumentException')->during('offsetExists', array('http://id.tincanapi.com/extension/topic'));
$this->shouldThrow('\InvalidArgumentException')->during('offsetGet', array('http://id.tincanapi.com/extension/topic'));
}

Expand Down
8 changes: 0 additions & 8 deletions spec/LanguageMapSpec.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,7 @@ function it_can_be_created_with_an_existing_array_map()
function it_returns_a_new_instance_with_an_added_entry()
{
$languageTag = $this->withEntry('en-US', 'attended');
$languageTag->offsetExists('en-US')->shouldReturn(true);
$languageTag->shouldNotBe($this);
$this->offsetExists('en-US')->shouldReturn(false);
}

function it_returns_a_new_instance_with_a_modified_entry()
Expand All @@ -63,12 +61,6 @@ function it_throws_an_exception_when_a_non_existent_language_tag_is_requested()
$this->shouldThrow('\InvalidArgumentException')->during('offsetGet', array('en-US'));
}

function it_can_be_asked_if_a_language_tag_is_known()
{
$this->offsetExists('en-GB')->shouldReturn(true);
$this->offsetExists('en-US')->shouldReturn(false);
}

function its_values_cannot_be_modified()
{
$this->shouldThrow('\LogicException')->during('offsetSet', array('en-US', 'attended'));
Expand Down
3 changes: 0 additions & 3 deletions spec/StateDocumentSpec.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,11 +39,8 @@ function it_is_a_document()

function its_data_can_be_read()
{
$this->offsetExists('x')->shouldReturn(true);
$this->offsetGet('x')->shouldReturn('foo');
$this->offsetExists('y')->shouldReturn(true);
$this->offsetGet('y')->shouldReturn('bar');
$this->offsetExists('z')->shouldReturn(false);
}

function it_throws_exception_when_not_existing_data_is_being_read()
Expand Down
Loading