Conversation
Author
|
Fixed conflict with master |
Contributor
|
Current version works for me and other people. Did you happen to investigate why it doesn't work for you? We also need to include some testing, otherwise it's hard to see if this actually works. |
Author
|
No didn't have time, but the existing syntax is obsolete. I used the now common syntax instead of the obsolete one and everything started working. That's good enough for me.
…On June 4, 2018 7:54:29 PM GMT+02:00, Alexander Shtuchkin ***@***.***> wrote:
Current version works for me and other people. Did you happen to
investigate why it doesn't work for you?
We also need to include some testing, otherwise it's hard to see if
this actually works.
--
You are receiving this because you authored the thread.
Reply to this email directly or view it on GitHub:
#166 (comment)
--
Sent from my Android device with K-9 Mail. Please excuse my brevity.
|
84ee650 to
9aa082f
Compare
|
@ashtuchkin In somehow I have to import iconv-lite from node_modules or other not import * as iconv from './node_modules/iconv-lite';its type dosn't have This type file requires importing by statement: import * as iconv-lite from 'iconv-lite'I support this commitment, but I have to fork a workaround repo at present. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TypeScript typings no longer worked somehow, this works.