Skip to content

Better deletion of Famous Nodes. #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
trusktr wants to merge 2 commits into
base: mixed-mode
Choose a base branch
from
Open

Better deletion of Famous Nodes. #20

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d4473bb
Better deletion of Node.
trusktr Aug 26, 2015
28bccca
Actually, better to use getParent() in case the user has moved the no…
trusktr Aug 27, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Node.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ class Node extends React.Component {
}

famousDelete() {
this._famousNode.dismount();
this._famousNode.getParent().removeChild(this._famousNode);
Copy link
Author

@trusktr trusktr Aug 27, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pilwon This throws if the node has no parent. Maybe we should check if the node has a parent first?

Copy link
Author

@trusktr trusktr Aug 27, 2015

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pilwon By the way, I've ben using react-famous on two projects. It's really nice (except for all the bugs in Famous itself right now)!

this._famousNode = null;
}

Expand Down