Open
Conversation
Fixed typos
Don't provide explicit repository address as this may confuse users working from a fork.
Update README.md
Owner
|
thanks for the PR. btw, there are some fixes you made in marker.sh are already present in the master branch, so you can remove them. |
pindexis
reviewed
Oct 5, 2017
bin/marker.sh
Outdated
| # move the cursor the next placeholder | ||
| function _move_cursor_to_next_placeholder { | ||
| match=$(echo "$BUFFER" | perl -nle 'print $& if m{{{.+?}}}' | head -n 1) | ||
| match=$(echo "$BUFFER" | perl -nle 'print $& if m{{.+?}}' | head -n 1) |
Owner
There was a problem hiding this comment.
I think I already fixed this on Sunday
added automagically adding of the added contents
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Amine,
It is nice to meet you.
Please find my pull request for new code I added to your awesome tool.
Many thanks,
Cristiano