-
Notifications
You must be signed in to change notification settings - Fork 34
codec(ticdc): improve error logging for Debezium encoding failures #3963
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
codec(ticdc): improve error logging for Debezium encoding failures #3963
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @takaidohigasi. Thanks for your PR. I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
Welcome @takaidohigasi! |
|
|
Summary of ChangesHello @takaidohigasi, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the debugging experience for Debezium encoding issues by enriching error logs with crucial contextual details. Previously, error messages were generic, but now they provide specific information about the database, table, column, and value that caused the failure, along with the commit timestamp, making it much easier to pinpoint and resolve problems. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request significantly improves error logging for Debezium encoding failures by adding valuable context like schema, table, column, and the problematic value. This will make debugging much easier.
My review includes one main suggestion to make the new logging code more robust. It addresses a potential panic when converting data to a string and improves the readability of logged binary data. Overall, this is a great enhancement.
Add detailed error logging when Debezium field value encoding fails. The error log now includes: - Schema name - Table name - Column name - Value (truncated to 1024 chars if too large, hex-encoded for binary types) - Commit timestamp This helps diagnose encoding issues like enum columns with invalid string values (e.g., issue #12474 in tiflow). Additionally, added panic recovery and hex encoding for binary types to ensure safe and readable error logging. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
5cf8307 to
260de85
Compare
|
Thanks for the review! I've addressed both concerns:
The updated code now safely handles both edge cases. See commit 260de85. |
|
/ok-to-test |
What problem does this PR solve?
Issue Number: close #3964
When Debezium encoding fails, the current error log lacks context information, making it difficult to debug which table/column caused the issue.
Related tiflow PR: pingcap/tiflow#12484
What is changed and how it works?
Improve error logging for Debezium encoding failures by adding detailed context information.
When Debezium encoding fails, the error log now includes:
schema: database/schema nametable: table namecolumn: column name that caused the errorvalue: the actual value (truncated to 1024 bytes if too large)commitTs: the commit timestamp of the eventThe
commitTsin the log can be used to skip problematic events using checkpoint override.Before:
After:
Check List
Tests
Questions
Will it cause performance regression or break compatibility?
No. This only affects error logging path which is not performance critical.
Do you need to update user documentation, design documentation or monitoring documentation?
No.
Release note