Skip to content

8C7fZGE5/4336-onnewnotification-handler-in-react-sdk #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sahandseifi merged 2 commits into from
Dec 20, 2025
Merged

8C7fZGE5/4336-onnewnotification-handler-in-react-sdk #61

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d9255ab
onNewNotifications handler
sahandseifi Dec 20, 2025
34ea972
Add onNewNotifications callback to React SDK
sahandseifi Dec 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 22 additions & 10 deletions lib/components/Provider/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@ type Props = (
webPushOptInMessage?: 'AUTOMATIC' | boolean;
customServiceWorkerPath?: string;
debug?: boolean;
onNewNotifications?: (notifications: InAppNotification[]) => void;
};

// Ensure that the code runs only in the browser
Expand Down Expand Up @@ -180,6 +181,25 @@ export const NotificationAPIProvider: React.FunctionComponent<
[debug]
);

const { onNewNotifications } = props;
const handleNewInAppNotifications = useCallback(
(notifications: InAppNotification[]) => {
debug.log('Received new in-app notifications via WebSocket', {
count: notifications?.length || 0,
notifications
});
playSound();
addNotificationsToState(notifications);
if (onNewNotifications) {
debug.log('Calling onNewNotifications callback', {
count: notifications?.length || 0
});
onNewNotifications(notifications);
}
},
[playSound, addNotificationsToState, onNewNotifications, debug]
);

const client = useMemo(() => {
debug.group('Initializing NotificationAPI client');

Expand All @@ -198,14 +218,7 @@ export const NotificationAPIProvider: React.FunctionComponent<
? props.client
: NotificationAPIClientSDK.init({
...clientConfig,
onNewInAppNotifications: (notifications) => {
debug.log('Received new in-app notifications via WebSocket', {
count: notifications?.length || 0,
notifications
});
playSound();
addNotificationsToState(notifications);
}
onNewInAppNotifications: handleNewInAppNotifications
});

// identify user
Expand All @@ -226,8 +239,7 @@ export const NotificationAPIProvider: React.FunctionComponent<
config.user.number,
config.hashedUserId,
config.debug,
addNotificationsToState,
playSound,
handleNewInAppNotifications,
props.client,
config.apiURL,
config.wsURL,
Expand Down