Skip to content

fix(android): Parent view steals map pan gesture #100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ottor-o wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

fix(android): Parent view steals map pan gesture #100

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 26 additions & 0 deletions android/src/main/java/com/rngooglemapsplus/GoogleMapsViewImpl.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,9 @@ import android.content.res.Configuration
import android.graphics.Bitmap
import android.location.Location
import android.util.Size
import android.view.MotionEvent
import android.view.View
import android.view.ViewGroup
import android.widget.FrameLayout
import androidx.lifecycle.Lifecycle
import androidx.lifecycle.findViewTreeLifecycleOwner
Expand Down Expand Up @@ -181,6 +183,30 @@ class GoogleMapsViewImpl(
}
}

private fun disallowParentTouchEventIntercept(disallowIntercept: Boolean): Boolean {
val parent = this.parent as? ViewGroup
if (parent != null) {
parent.requestDisallowInterceptTouchEvent(disallowIntercept)
return true
}
return false
}

override fun dispatchTouchEvent(ev: MotionEvent): Boolean {
when (ev.actionMasked) {
MotionEvent.ACTION_DOWN -> {
disallowParentTouchEventIntercept(
googleMap?.uiSettings?.isScrollGesturesEnabled ?: false
)
}
MotionEvent.ACTION_UP -> {
disallowParentTouchEventIntercept(false)
}
}
super.dispatchTouchEvent(ev)
return true
}

override fun onCameraMoveStarted(reason: Int) =
onUi {
if (!mapViewLoaded) return@onUi
Expand Down
Loading