Skip to content

Conversation

@mengelbart
Copy link
Contributor

No description provided.

@mengelbart mengelbart requested a review from JoTurk January 31, 2026 19:41
@JoTurk
Copy link
Member

JoTurk commented Jan 31, 2026

@mengelbart should we finally release this logger?

@codecov
Copy link

codecov bot commented Jan 31, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.23%. Comparing base (033f530) to head (1e0b59d).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #142      +/-   ##
==========================================
- Coverage   88.36%   88.23%   -0.13%     
==========================================
  Files           3        3              
  Lines         275      272       -3     
==========================================
- Hits          243      240       -3     
  Misses         24       24              
  Partials        8        8              
Flag Coverage Δ
go 88.23% <ø> (-0.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

@philipch07 philipch07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this, sorry I didn't realize this sooner 😅

@mengelbart
Copy link
Contributor Author

I would like to have JSON logging released, but just want to point out that it does not do what the example says it does, see: #143

@philipch07
Copy link
Contributor

I have a PR ready, just need to rebase it on this, so I'll merge it now @mengelbart.

@philipch07 philipch07 merged commit 62cbfd2 into master Jan 31, 2026
19 checks passed
@philipch07 philipch07 deleted the use-default-timestamps branch January 31, 2026 20:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

4 participants