Skip to content

Conversation

@philipch07
Copy link
Contributor

Description

Update the remaining chunk files to RFC 9260 with the exception of chunk-reconfig which follows RFC 6525 and requires more updates in association.go.

Requires #427 to be merged first.

Reference issue

Resolves #426.

@codecov
Copy link

codecov bot commented Nov 8, 2025

Codecov Report

❌ Patch coverage is 47.43083% with 133 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.70%. Comparing base (9ee8305) to head (5943c82).

Files with missing lines Patch % Lines
chunk_heartbeat_ack.go 0.00% 31 Missing ⚠️
chunk_heartbeat.go 0.00% 25 Missing ⚠️
chunk_error.go 55.55% 11 Missing and 5 partials ⚠️
chunk_init_common.go 64.44% 8 Missing and 8 partials ⚠️
chunk_selective_ack.go 62.50% 7 Missing and 8 partials ⚠️
chunk_abort.go 68.75% 7 Missing and 3 partials ⚠️
chunk_init_ack.go 14.28% 5 Missing and 1 partial ⚠️
chunk_payload_data.go 37.50% 3 Missing and 2 partials ⚠️
chunk_cookie_echo.go 33.33% 2 Missing and 2 partials ⚠️
chunk_forward_tsn.go 83.33% 1 Missing and 2 partials ⚠️
... and 1 more

❌ Your patch check has failed because the patch coverage (47.43%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #433      +/-   ##
==========================================
- Coverage   83.90%   81.70%   -2.21%     
==========================================
  Files          51       51              
  Lines        3448     3585     +137     
==========================================
+ Hits         2893     2929      +36     
- Misses        416      491      +75     
- Partials      139      165      +26     
Flag Coverage Δ
go 81.70% <47.43%> (-2.21%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JoTurk
Copy link
Member

JoTurk commented Nov 8, 2025

i think we should break this into multiple PRs, I'm fine with reviewing it as a single one tho.

@philipch07 philipch07 force-pushed the pch07/update-chunk-remaining-9260 branch from 1993713 to 5943c82 Compare November 8, 2025 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update chunk stuff to RFC 9260

3 participants