This repository was archived by the owner on Nov 7, 2018. It is now read-only.
Allow modifying elasticsearch.yml using environment variables#52
Open
patricktoelle wants to merge 6 commits intopires:masterfrom
Open
Allow modifying elasticsearch.yml using environment variables#52patricktoelle wants to merge 6 commits intopires:masterfrom
patricktoelle wants to merge 6 commits intopires:masterfrom
Conversation
Use ENV to add elasticsearch-keystore entries
Allow modifying elasticsearch.yml using environment variables
pires
suggested changes
Jan 26, 2018
Owner
pires
left a comment
pires
left a comment
There was a problem hiding this comment.
I'm not comfortable with this PR. Also, the commit log needs to be cleaned-up.
| * [MEMORY_LOCK](https://www.elastic.co/guide/en/elasticsearch/reference/current/important-settings.html#bootstrap.memory_lock) - memory locking control - enable to prevent swap (default = `true`) . | ||
| * [REPO_LOCATIONS](https://www.elastic.co/guide/en/elasticsearch/reference/current/modules-snapshots.html#_shared_file_system_repository) - list of registered repository locations. For example `["/backup"]` (default = `[]`). | ||
| * [PROCESSORS](https://github.com/elastic/elasticsearch-definitive-guide/pull/679/files) - allow elasticsearch to optimize for the actual number of available cpus (must be an integer - default = 1) | ||
| * ES_CONFIG_* - add any entries to elasticsearch.yml by prodiving multiple variables. Double underscore will be replaced with dots, e.g. ES_CONFIG_S3__CLIENT__MINIO__PROTOCOL='http' ends up as s3.client.minio.protocol: http |
Owner
There was a problem hiding this comment.
This should be properly documented in a separate section.
* commit 'a928e6e': Upgrade Elasticsearch to version 6.1.3
pires
force-pushed
the
master
branch
3 times, most recently
from
738723d to
e14ad80
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To add any additional configuration to elasticsearch.yml, you can use environment variables ES_CONFIG_*. As already done for elasticsearch-keystore, all variables starting with ES_CONFIG_ get evaluated and will be placed in elasticsearch.yml before starting ES.
This PR needs to get #50 to get merged first to avoid merge conflicts.