Resolve compiler warnings to comply with -Werror; tabs to spaces#8
Open
zyphlar wants to merge 1 commit intopixelmatix:masterfrom
Open
Resolve compiler warnings to comply with -Werror; tabs to spaces#8zyphlar wants to merge 1 commit intopixelmatix:masterfrom
zyphlar wants to merge 1 commit intopixelmatix:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When compiling under Ubuntu it fails because warnings about an unused int and unguarded (oddly-indented) else are treated as errors. This fixes that with a few curly braces and commented-out lines, and reduces future indent chaos by moving to spaces for indentation plus a bit of cleanup. (I don't care about spaces or tabs, but the source file was inconsistent/mixed)
Here's the
git diff -w: