Compare Function for Rational/BigRational #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ew Rational in tests)
…update; BigRational implemented
scheibo
reviewed
Mar 27, 2025
scheibo
reviewed
Mar 27, 2025
| fn cmp_(comptime T: type, comptime o: comptime_int, r: anytype, s: anytype) !std.math.Order { | ||
| switch (@typeInfo(T)) { | ||
| Int => { | ||
| r.reduce(); |
Contributor
There was a problem hiding this comment.
I think you want to lazily reduce in this function on overflow like the others, no?
Contributor
There was a problem hiding this comment.
you didnt remove the eager reduction?
scheibo
reviewed
Mar 27, 2025
Contributor
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds comparison methods to both
RationalandBigRationalstructs for faster comparisons instead of converting to floatsBoth return
std.math.Orderenums dictating the comparison order