Open
Conversation
josephschorr
added a commit
to josephschorr/spicedb
that referenced
this pull request
Mar 11, 2024
By making the serialized caveat expressions stable, the diff should only return a change now when the caveat expr's has actually changed, rather than pretty much always, thus reducing the storage for "changed" caveats Fixes authzed#1742 We should go back to MarshalVT once planetscale/vtprotobuf#133 has merged
Contributor
|
+1, we have a similar use case of our proto wire format being hashed to compare equality where this would help. I do wonder if we should just modify "strict" to do this as well? Maybe less desirable now that Strict is already shipped though for compatibility |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Hi, I am currently trying to apply the SpiceDB, which utilize
vtprotovufto marshal/unmarshal the db records. Unfortunately, the data itself contains some map fields, which in result will create the nondeterministic serialized results and mess things up when trying to determine whether the data is updated or not.(https://github.com/authzed/spicedb/blob/5d0eb901634999bbccc7269af2ea582872812a6b/pkg/diff/caveats/diff.go#L155)
In short, I wish to have a plugin being able to support deterministic marshaling behaviors, just like what was mentioned in the issue: #82.
The PR adjusted the marshal plugin like the one in #44.