Skip to content

feat: authorization model store path renaming #258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
OlegErshov merged 22 commits into from
Jan 16, 2026
Merged

feat: authorization model store path renaming #258

OlegErshov merged 22 commits into from
Jan 16, 2026

Conversation

@OlegErshov
Copy link
Contributor

@OlegErshov OlegErshov commented Jan 8, 2026 •
edited
Loading

This pr is related to #174

Changes:

  1. The field Spec.StoreRef.Path has been renamed into Spec.StoreRef.Cluster in v1alpha1 version
  2. Introduced a function to migrate existing authorization models before the manager starts

@OlegErshov
chore: renamed store referenece path into cluster field
004ef42 
On-behalf-of: SAP aleh.yarshou@sap.com
@OlegErshov
feat: introduce v1alpha2 api version
241afff 
On-behalf-of: SAP aleh.yarshou@sap.com
@OlegErshov
feat: renamed field in v1alpha1 version and introduced a migration fu…
2e443df 
…nction

On-behalf-of: SAP aleh.yarshou@sap.com
@OlegErshov OlegErshov self-assigned this Jan 8, 2026
@OlegErshov OlegErshov changed the title Feat/authz model store path renaming feat: authorization model store path renaming Jan 8, 2026
OlegErshov and others added 4 commits January 8, 2026 18:05
@OlegErshov
Merge branch 'main' into feat/authz-model-store-path-renaming
a365296
@OlegErshov
fix: updated resource schema
97d8597 
On-behalf-of: SAP aleh.yarshou@sap.com
@OlegErshov
use patch instead of update
3fda111 
On-behalf-of: SAP aleh.yarshou@sap.com
@OlegErshov
chore:fixed typos
c2b74bd 
On-behalf-of: SAP aleh.yarshou@sap.com
@OlegErshov OlegErshov marked this pull request as ready for review January 8, 2026 16:04
@OlegErshov OlegErshov linked an issue Jan 8, 2026 that may be closed by this pull request
Rename WorkspaceStoreRef.Path to WorkspaceStoreName.Cluster since we don't use the human readable path #174
Closed
5 tasks
aaronschweig
aaronschweig requested changes Jan 12, 2026
View reviewed changes
aaronschweig
aaronschweig requested changes Jan 13, 2026
View reviewed changes
Copy link
Contributor

@aaronschweig aaronschweig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

next round of feedback

@OlegErshov
switched to the typed approach
7f465f2 
On-behalf-of: SAP aleh.yarshou@sap.com
@OlegErshov
placed logicalClusterClientFromKey function usage only within Run fun…
63b57aa 
…ctions

On-behalf-of: SAP aleh.yarshou@sap.com
OlegErshov and others added 3 commits January 16, 2026 12:22
@OlegErshov OlegErshov merged commit 4bb6860 into main Jan 16, 2026
11 checks passed
@OlegErshov OlegErshov deleted the feat/authz-model-store-path-renaming branch January 16, 2026 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aaronschweig aaronschweig aaronschweig approved these changes

@coderabbitai coderabbitai[bot] coderabbitai[bot] approved these changes

Assignees

@OlegErshov OlegErshov

Labels

chore feature fix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Rename WorkspaceStoreRef.Path to WorkspaceStoreName.Cluster since we don't use the human readable path

3 participants

@OlegErshov @aaronschweig