PCD-5136: SOC2 file addition #3
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![windsurf-bot[bot]](https://avatars.githubusercontent.com/in/1066231?s=60&v=4){kind=small}
There was a problem hiding this comment.
Other comments (3)
- .github/workflows/security-scan.yml (47-51) There's a mismatch in the bandit scan configuration. The scan uses `--severity-level medium` (which includes medium and high), but the output processing only checks for HIGH severity issues. Consider either changing the scan to `--severity-level high` or updating the output processing to include medium severity issues as well.
- .github/workflows/security-scan.yml (5-7) The workflow contains hardcoded branch names that appear to be personal development branches (`private/harsh/soc2-scan`, `private/soc2`). These should be removed before merging to master to avoid unnecessary workflow runs.
- .github/workflows/security-scan.yml (18-18) The workflow is using actions/checkout@v3 in multiple places. Consider upgrading to actions/checkout@v4 for improved security and features.
💡 To request another review, post a new comment with "/windsurf-review".
.github/workflows/lint.yml
Outdated
Comment on lines
60
to
64
| body: | | ||
| ## ⚠️ Ruff Lint Issues Found | ||
| See `.ruff_output.txt` for full details. | ||
| branch: auto/ruff-lint-issues | ||
| base: atherton |
There was a problem hiding this comment.
The 'branch' and 'base' parameters are incorrectly indented as part of the PR body text. They should be at the same level as other parameters.
Suggested change
| body: | | |
| ## ⚠️ Ruff Lint Issues Found | |
| See `.ruff_output.txt` for full details. | |
| branch: auto/ruff-lint-issues | |
| base: atherton | |
| body: | | |
| ## ⚠️ Ruff Lint Issues Found | |
| See `.ruff_output.txt` for full details. | |
| branch: auto/ruff-lint-issues | |
| base: atherton |
.github/workflows/lint.yml
Outdated
Comment on lines
65
to
66
| add-paths: | | ||
| ruff_output.txt |
There was a problem hiding this comment.
The 'add-paths' parameter has incorrect formatting. The file path should be properly indented.
Suggested change
| add-paths: | | |
| ruff_output.txt | |
| add-paths: | | |
| ruff_output.txt |
.github/workflows/lint.yml
Outdated
| ## ⚠️ Ruff Lint Issues Found | ||
| See `.ruff_output.txt` for full details. | ||
| branch: auto/ruff-lint-issues | ||
| base: atherton |
There was a problem hiding this comment.
The workflow is configured to create auto-fix PRs against the 'atherton' branch, but this PR is targeting 'master'. Consider aligning these to ensure auto-fixes target the correct branch.
hsri-pf9
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.