Skip to content

Fixed: WP Rocket compatibility. #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Dan0sz merged 1 commit into from
Jan 24, 2025
Merged

Fixed: WP Rocket compatibility. #235

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 20 additions & 4 deletions src/Compatibility.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,8 @@ public function __construct() {
add_filter( 'rocket_excluded_inline_js_content', [ $this, 'exclude_plausible_inline_js' ] );
add_filter( 'rocket_exclude_js', [ $this, 'exclude_plausible_js' ] );
add_filter( 'rocket_minify_excluded_external_js', [ $this, 'exclude_plausible_js' ] );
add_filter( 'rocket_delay_js_scripts', [ $this, 'exclude_plausible_js' ] );
add_filter( 'rocket_delay_js_exclusions', [ $this, 'exclude_plausible_inline_js' ] );
add_filter( 'rocket_exclude_defer_js', [ $this, 'exclude_plausible_js_by_relative_url' ] );
}
}

Expand Down Expand Up @@ -86,9 +87,7 @@ public function exclude_plausible_js_as_string( $exclude_js ) {
* @return array
*/
public function exclude_plausible_inline_js( $inline_js ) {
if ( ! isset( $inline_js[ 'plausible' ] ) ) {
$inline_js[ 'plausible' ] = 'window.plausible';
}
$inline_js[ 'plausible' ] = 'window.plausible';

return $inline_js;
}
Expand All @@ -110,6 +109,23 @@ public function exclude_plausible_js( $excluded_js ) {
return $excluded_js;
}

/**
* Dear WP Rocket/SG Optimizer/Etc., don't minify/combine/delay our external JS, please.
*
* @filter rocket_exclude_js
* @filter rocket_minify_excluded_external_js
* @since 1.2.5
*
* @param array $excluded_js
*
* @return array
*/
public function exclude_plausible_js_by_relative_url( $excluded_js ) {
$excluded_js[] = preg_replace( '/http[s]?:\/\/.*?(\/)/', '$1', Helpers::get_js_url( true ) );

return $excluded_js;
}

/**
* Dear WP Rocket/SG Optimizer/Etc., don't minify/combine/delay our external JS, please.
*
Expand Down
Loading