Skip to content

[FEAT] Use signed urls for launch page #1735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kpal81xd wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[FEAT] Use signed urls for launch page #1735

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f51c701
use signed urls for launch page (#1723)
isumygin-sc Feb 10, 2026
b4eb65b
Merge branch 'main' into signed-urls
kpal81xd Feb 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion modules/editor-api/external/types/config.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -231,5 +231,6 @@ export type LaunchConfig = {
oneTrustDomainKey: string,
schema: ModelSchema,
engineVersions: EngineVersions,
wasmModules?: WasmModule[]
wasmModules?: WasmModule[],
signedUrls?: Record<string, string>
};
12 changes: 11 additions & 1 deletion src/launch/assets/assets-sync.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -94,13 +94,23 @@ editor.once('load', () => {
if (assetData.file) {
if (concatenateScripts && assetData.type === 'script' && assetData.file.filename.endsWith('.js') && assetData.preload && !assetData.data.loadingType) {
assetData.file.url = concatenatedScriptsUrl;
} else if (config.signedUrls && config.signedUrls[assetData.id]) {
// Use pre-signed CloudFront URL
assetData.file.url = config.signedUrls[assetData.id];
delete assetData.file.hash;
} else {
assetData.file.url = getFileUrl(assetData.path, assetData.id, assetData.revision, assetData.file.filename);
}

if (assetData.file.variants) {
for (key in assetData.file.variants) {
assetData.file.variants[key].url = getFileUrl(assetData.path, assetData.id, assetData.revision, assetData.file.variants[key].filename);
const variantSignedKey = `${assetData.id}:${key}`;
if (config.signedUrls && config.signedUrls[variantSignedKey]) {
assetData.file.variants[key].url = config.signedUrls[variantSignedKey];
delete assetData.file.variants[key].hash;
} else {
assetData.file.variants[key].url = getFileUrl(assetData.path, assetData.id, assetData.revision, assetData.file.variants[key].filename);
}
}
}
}
Expand Down