Merged
Conversation
mvaligursky
approved these changes
Aug 6, 2020
Collaborator
|
It didn't came up when I ran |
Member
Author
|
Yeah you're right @Maksims. CI didn't complain and I only saw the error when building the minified engine locally. Would be good to get this caught earlier on. |
TheJonRobinson
added a commit
to Mojiworks/playcanvas-engine
that referenced
this pull request
Sep 6, 2020
* stable: (60 commits) [RELEASE] v1.34.0 [FIX] Compile fix (playcanvas#2368) add test when patching container multiple times (playcanvas#2367) Add documentation for pc.Element#mask (playcanvas#2366) Anim optimizations (playcanvas#2354) Added example code for curve and curve set (playcanvas#2353) Specify basis URL config (playcanvas#2359) construct node hierarchy even when no model exists (playcanvas#2358) Adding support for json script attributes with a schema (1 level deep) (playcanvas#2234) [Fix] Glb converts 32bit index buffer to 16 if device does not support it (playcanvas#2349) [Fix] gpu size calculation for PIXELFORMAT_L8_A8 and mipmaps (playcanvas#2350) Fix spelling for Arm (playcanvas#2344) [Fix] improve compatibility of example with older mobile devices (playcanvas#2348) [Fix] Mini-stats uses 16bit index buffer insead of 32 (playcanvas#2347) [VERSION] v1.34.0-dev [RELEASE] v1.33.1 Fix overbright cubemaps (playcanvas#2342) [VERSION] v1.34.0-dev [RELEASE] v1.33.0 Fix webxr lint failure (playcanvas#2341) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix linting errors introduced in #2316
I confirm I have signed the Contributor License Agreement.