WebXR Plane Detection#3068
Merged
willeastcott merged 17 commits intoplaycanvas:masterfrom Jun 15, 2021
Merged
Conversation
Collaborator
Author
|
I'm not sure how to deal with a TypeScript error as it fails to find XRPlane, and not sure where to add a "polyfill" for such a test. Please advice @mvaligursky #typescript-problems |
mvaligursky
reviewed
Apr 7, 2021
mvaligursky
reviewed
Apr 8, 2021
mvaligursky
reviewed
Apr 8, 2021
mvaligursky
reviewed
Apr 8, 2021
mvaligursky
reviewed
Apr 8, 2021
mvaligursky
reviewed
Apr 8, 2021
mvaligursky
approved these changes
Apr 8, 2021
Collaborator
|
Self note: add project https://playcanvas.com/project/782753/overview/webxr-plane-detection to tutorials section |
willeastcott
approved these changes
Jun 15, 2021
Contributor
|
OK, LGTM now, @Maksims. Can you resolve the |
Contributor
Collaborator
Author
src/xr/xr-manager.js
Outdated
| * }); | ||
| * @param {object} [options] - Object with additional options for XR session initialization. | ||
| * @param {string[]} [options.optionalFeatures] - Optional features for XRSession start. It is used for getting access to additional WebXR spec extensions. | ||
| * @param {boolean} [options.depthSensing] - Set to true to attempt to enable {@link XrDepthSensing}. |
Contributor
There was a problem hiding this comment.
This is a duplicate of the param definition at line 190
Contributor
There was a problem hiding this comment.
Except that declaration is an object
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Implementation of an experimental draft spec: https://immersive-web.github.io/real-world-geometry/plane-detection.html
It is available in Chrome for Android 89, with enabled chrome://flags#webxr-incubations flag.
Plane detection provides information about real-world surfaces estimations in form of planes.
Each plane can have its position, rotation and a list of edge points making a complex polygon.
New APIs:
Test project:
https://playcanvas.com/project/782753/overview/webxr-plane-detection
This project builds mesh, updates it when the plane is changed and draw lines for each detected plane.
Test build:
https://playcanv.as/p/f2ESRGge/
Ensure you have chrome://flags#webxr-incubations enabled
Video:
https://twitter.com/mrmaxm/status/1379802592163864581
I confirm I have signed the Contributor License Agreement.