Conversation
Collaborator
Author
|
Help, #typescriptproblems. Not sure how to deal with this problem. :( |
Collaborator
|
@Maksims Looks like the issue is: In callback.js, it's missing XrAnchorCreate Add something like this to callbacks.js PS Sorry about the late reply, only just saw that you needed help 😅 |
Contributor
|
More merge conflicts here too @Maksims. 😄 |
Collaborator
Author
|
Updated this PR to be mergeable, but get two errors with TypeScript Declarations (#typescriptissues....). |
willeastcott
reviewed
Aug 8, 2023
willeastcott
reviewed
Aug 9, 2023
willeastcott
reviewed
Aug 9, 2023
willeastcott
reviewed
Aug 9, 2023
willeastcott
reviewed
Aug 9, 2023
willeastcott
reviewed
Aug 9, 2023
willeastcott
approved these changes
Aug 9, 2023
Contributor
willeastcott
left a comment
There was a problem hiding this comment.
Approving with final round of feedback. I'll merge when those are addressed. Thanks! 🚀
Co-authored-by: Will Eastcott <will@playcanvas.com>
Co-authored-by: Will Eastcott <will@playcanvas.com>
Co-authored-by: Will Eastcott <will@playcanvas.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementation of an experimental draft spec: https://github.com/immersive-web/anchors/blob/main/explainer.md
It is available in Chrome for Android.
Anchors provide an ability to specify a point in the world that need to be updated to correctly reflect the evolving understanding of the world by the underlying AR system, such that the anchor remains aligned with the same place in the physical world. Anchors tend to persist better relative to the real world, especially during a longer session with lots of movement.
Current WebXR Anchors spec provides persistence features - Anchors can provide persistent UID, that can be used to restore them between sessions. But currently Chrome for Android 115 - does not support it.
New APIs:
Test project:
https://playcanvas.com/project/785123/overview/webxr-ar-anchors
This project relies on Hit Test API and allows to place anchors by tapping on surfaces.
Test Build:
https://playcanv.as/p/Skq3Ry1K/
I confirm I have signed the Contributor License Agreement.