[FIX] Fix duplicate XrViews instance and clean up handler in XrManager#8392
Merged
willeastcott merged 1 commit intomainfrom Jan 20, 2026
Merged
[FIX] Fix duplicate XrViews instance and clean up handler in XrManager#8392willeastcott merged 1 commit intomainfrom
willeastcott merged 1 commit intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes three issues in the XrManager class: a duplicate XrViews instantiation that caused a memory leak, a missing cleanup handler for the 'frameratechange' event listener, and an incorrect JSDoc comment.
Changes:
- Removed duplicate
XrViewsinstantiation in constructor (line 307) - Refactored
frameratechangeevent listener to use a named functiononFrameRateChangethat can be properly cleaned up - Corrected JSDoc comment in
end()method to say "ended" instead of "started"
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
willeastcott
added a commit
that referenced
this pull request
Jan 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
XrViewsinstantiation in constructor that was accidentally introduced in WebXR Depth Camera #5848, causing memory leakframeratechangeevent listener never being removed when XR session endsend()method that said "started" instead of "ended"Checklist