Refactor data texture creation using internal Texture helper#8457
Merged
mvaligursky merged 1 commit intomainfrom Feb 13, 2026
Merged
Refactor data texture creation using internal Texture helper#8457mvaligursky merged 1 commit intomainfrom
mvaligursky merged 1 commit intomainfrom
Conversation
Add Texture.createDataTexture2D as an internal API and migrate repeated nearest/clamp/no-mipmap 2D texture creation to this helper, including optional levels upload support. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
|
I would create a separate DataTexture class; I can provide an example. This class would have an API for updating cells/rows and other functionality. |
Contributor
Author
Hmm, not sure this is something particularly needed for the internal use in the engine? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Texture.createDataTexture2D(graphicsDevice, name, width, height, format, levels)helper for nearest-filtered, clamp-to-edge, no-mipmap 2D data texturesnew Texture(...)option blocks with the helper across picker, post-effect queue, gsplat-unified paths, light atlas, depth grab, prepass, and SSAOGSplatWorkBuffer._createTexturesince it became a direct pass-through to the new helper