Fix: eyedropper and flood selection to reapply when threshold changes#770
Open
reagan99 wants to merge 2 commits intoplaycanvas:mainfrom
Open
Fix: eyedropper and flood selection to reapply when threshold changes#770reagan99 wants to merge 2 commits intoplaycanvas:mainfrom
reagan99 wants to merge 2 commits intoplaycanvas:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes an issue where the Eyedropper and Flood selection tools did not update the current selection when the threshold value was changed after clicking. Previously, users had to click again for the new threshold to take effect. With this change, the selection is immediately recomputed whenever the threshold changes.
Changes
Files Changed
Test Plan