-
-
Notifications
You must be signed in to change notification settings - Fork 32
Replace browserDefault with is_default_page #310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
@gforcada thanks for creating this Pull Request and helping to improve Plone! TL;DR: Finish pushing changes, pass all other checks, then paste a comment: To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically. Happy hacking! |
|
@jenkins-plone-org please run jobs |
fbaffc3 to
0ac31c9
Compare
Rather than a CMFPlone script from skins folder.
0ac31c9 to
ddb724a
Compare
Co-authored-by: David Glick <david@glicksoftware.com>
…er than the ``plone_utils`` tool. Also, check if an item is a default page in its own container, instead of on the context where we see the reviewlist.
|
I added a few commits, updating the news snippet and using I also saw similar code in
BTW, the checkboxes here are useless, as no buttons are shown that would do anything with the suggestion. But that is a different issue. @gforcada Sorry for hijacking your PR! Hope it's okay. |
|
@jenkins-plone-org please run jobs |

So we remove the last usage of
browserDefaultand thus can be removed from CMFPlone.See plone/Products.CMFPlone#3737