Skip to content

Conversation

@gforcada
Copy link
Member

@gforcada gforcada commented Aug 17, 2025

So we remove the last usage of browserDefault and thus can be removed from CMFPlone.

See plone/Products.CMFPlone#3737

@mister-roboto
Copy link

@gforcada thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@gforcada gforcada changed the title Use plone base Replace browserDefault with is_default_page Aug 17, 2025
@gforcada
Copy link
Member Author

@jenkins-plone-org please run jobs

mauritsvanrees and others added 4 commits December 19, 2025 11:02
Co-authored-by: David Glick <david@glicksoftware.com>
…er than the ``plone_utils`` tool.

Also, check if an item is a default page in its own container, instead of on the context where we see the reviewlist.
@mauritsvanrees
Copy link
Member

I added a few commits, updating the news snippet and using aq_parent instead of __parent__. Maybe those should have been suggestions.

I also saw similar code in reviewlist.py. It was not using the skin script, but it was calling the same function from plone_utils, and handling it with the slightly confusing code that that you replaced. So I updated it here as well. The full_review_list page (linked from the review portlet) now shows like this:

Screenshot 2025-12-19 at 11 56 12

BTW, the checkboxes here are useless, as no buttons are shown that would do anything with the suggestion. But that is a different issue.

@gforcada Sorry for hijacking your PR! Hope it's okay.

@mauritsvanrees
Copy link
Member

@jenkins-plone-org please run jobs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants