Makefile: Add easy support for sanitizers#298
Open
ferivoz wants to merge 2 commits intoplougher:masterfrom
Open
Makefile: Add easy support for sanitizers#298ferivoz wants to merge 2 commits intoplougher:masterfrom
ferivoz wants to merge 2 commits intoplougher:masterfrom
Conversation
Fixes an issue when compiling with sanitizers which otherwise prevents mksquashfs from successful linking. Added bonus is that visibility is reduced from a C point of view as well. Simplifies code auditing. Signed-off-by: Samanta Navarro <ferivoz@riseup.net>
This simplifies the addition of sanitizers to executables for easier debugging. Signed-off-by: Samanta Navarro <ferivoz@riseup.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have to make local adjustments in the code to use ASAN and UBSAN. I think that it's a compiler issue, but both commits should be beneficial for squashfs-tools regardless.
Adding ASAN and UBSAN is simple now: