[inferno-ml-server] Fix argument position when applying scripts#188
Merged
[inferno-ml-server] Fix argument position when applying scripts#188
Conversation
shulhi
approved these changes
Dec 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
He had an issue where
inferno-ml-serverexpected function arguments to be in a specific order, but we can't always expect that (as a subtle bug recently demonstrated). So this fixes it to extract all arguments from theLamin theVCFunction, then do aMap.lookupon all inputs/outputs/models to reconstruct the correct ordering to apply the function. This makesinferno-ml-serverwork with any argument ordering, which is far more resilient and doesn't rely on fragile ordering/sorting guarantees to be synchronized everywhere