Draft
Conversation
Co-authored-by: pmxi <64939659+pmxi@users.noreply.github.com>
Co-authored-by: pmxi <64939659+pmxi@users.noreply.github.com>
Co-authored-by: pmxi <64939659+pmxi@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Refactor duplicated code for better maintainability
Eliminate duplicated _escape_markdown method
Nov 6, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #(issue number)
Description
The
_escape_markdownmethod had identical implementations in bothTelegramNotifierandTelegramEmailNotifierclasses.Changes:
TelegramEmailNotifier(36 lines)_escape_markdowntoescape_markdowninTelegramNotifier(now public API)TelegramEmailNotifierto delegate toself.notifier.escape_markdown()Before:
After:
Net -26 lines. Single source of truth for Telegram markdown escaping.
Tradeoffs
Made
escape_markdownpublic to maintain proper encapsulation rather than accessing a private method across classes. This is the correct design but expands the public API surface.Alternatives
Considered creating a shared utility module, but the method is Telegram-specific and belongs in
TelegramNotifier. Current solution leverages existing composition relationship between the classes.Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.