Add option to prevent auto-termination after MCAP playback#31
Conversation
* run.default with params now works written in README.md
* To meet our requirements, controlling shutdown condition in `Run` class is needed
|
Hey thanks so much for the contribution @f0reachARR!! The structure here looks great, but I would like to see some testing coverage for this option. There are number of examples under |
|
Also any chance you could describe your use case in more detail? How do you terminate the test? |
|
Thank you for the advice! I’ve added the tests and the README. I would like to use replay_testing not only for sensing but also for simulations. |
|
amazing! thanks the README and tests look good. I'll merge once CI passes. Thanks so much for your contribution 😄 |
|
Looks like |
|
Sorry for mistakes! I just ran |
|
@f0reachARR merged! Thanks so much for your contribution! |
Thank you for developing this awesome testing tool!
This PR proposes small improvements to better suit our use case.
Issue: Currently, the launch terminates automatically when MCAP playback finishes. We need to observe system behavior for some time after playback ends.
Changes:
ignore_playback_finishoption to prevent automatic launch termination after MCAP playback completesrun.defaultusage example in README.md (the previous exampleClock Configurationcaused errors)