Draft
Conversation
Member
|
Decisions for .janno column changes:
|
Member
|
For unix line endings: Packages should be checked for that and a warning thrown (one per package). They should be read anyway, though. |
Member
Author
|
Rough division of labour:
|
Member
This reverts commit 05a23a1.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #351 +/- ##
=======================================
Coverage 56.83% 56.83%
=======================================
Files 33 33
Lines 4993 4993
Branches 546 546
=======================================
Hits 2838 2838
Misses 1609 1609
Partials 546 546 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
I finally went ahead and reverted 05a23a1 to turn this PR to a clean slate for all Poseidon v3.0.0-related changes. I also redirected #357 to be merged into this branch. So I think the next steps should be as follows:
|
Member
Author
|
OK, I finished #356 and will now start with the YAML and Poseidon_ID changes. |
Yaml changes v3
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.