Poseidon version cli for validate and jannocoalesce#367
Poseidon version cli for validate and jannocoalesce#367nevrome wants to merge 3 commits intoposeidon300colsfrom
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## poseidon300cols #367 +/- ##
===================================================
- Coverage 55.70% 55.56% -0.14%
===================================================
Files 33 33
Lines 5235 5248 +13
Branches 631 631
===================================================
Hits 2916 2916
- Misses 1688 1701 +13
Partials 631 631 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
stschiff
left a comment
There was a problem hiding this comment.
Hmm, I'm still a bit confused. So you now have VersionedFiles as Input and Output. So for input this makes sense, as upon reading, the parser has to know which version, so that it can for example scale the damage and endogenous values. But for writing, how does this exactly work? Say I request things to be written as 2.7.1. Then this line here:
JannoRows targetRows <- readJannoFile targetPV [] targetPathwill work just fine. But that doesn't mean that the writing will properly respect the version?
I think the writing will always write in Version 3.0.0 format, won't it?
Perhaps we should make this simple, and forbid any choice of the target version to be selected? Maybe this needs to be discussed.
In your review of #357 you remarked that validate and jannocoalesce should not be limited to the latest Poseidon version, @stschiff. This PR adds command line options to set the versions manually.