remove map_dfr - fixes posit-dev/connectapi#422#496
Open
AntLP wants to merge 2 commits intoposit-dev:mainfrom
Open
remove map_dfr - fixes posit-dev/connectapi#422#496AntLP wants to merge 2 commits intoposit-dev:mainfrom
AntLP wants to merge 2 commits intoposit-dev:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Intent
As described in the issue, some functions had a dependency on
dplyrthrough the use ofpurrr::map_dfandpurrr::map_dfr.Fixes #422
Approach
Replaced the calls to
purrr::map_dfandpurrr::map_dfrwith a combination ofpurrr::mapandpurrr::list_rbind, which removes the dependency ondplyr.I did not remove the
purrr::map_dfrusages in the tests,dplyris therefore still required to run the tests.Checklist
NEWS.md(referencing the connected issue if necessary)?devtools::document()?