remove make_source_manifest in favor of Manifest class#477
Open
remove make_source_manifest in favor of Manifest class#477
Conversation
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
mmarchetti
approved these changes
Sep 11, 2023
Contributor
mmarchetti
left a comment
mmarchetti
left a comment
There was a problem hiding this comment.
Looks good! We will need to do some QA on this before merging; probably best to do that after we finish the current release that is in beta.
omar-rs
approved these changes
Sep 11, 2023
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed there was a lot of code shared between
Manifestandmake_source_manifest. These changes are going to be useful for an upcoming PR for some Posit Cloud changes.